Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rosenbrock 3rd order perform_step! refactor #2463

Closed
wants to merge 65 commits into from
Closed

Rosenbrock 3rd order perform_step! refactor #2463

wants to merge 65 commits into from

Conversation

ParamThakkar123
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.
solves a part of #233

ParamThakkar123 and others added 30 commits August 25, 2024 23:36
@ParamThakkar123
Copy link
Contributor Author

@oscardssmith can you please review ? Your reviews can help me move forward with this PR. So I can fix the errors and we can get this merged.

@ParamThakkar123
Copy link
Contributor Author

@oscardssmith can you please review ? Your reviews can help me move forward with this PR. So I can fix the errors and we can get this merged.

@ChrisRackauckas Can you please review this PR. ??

@ParamThakkar123
Copy link
Contributor Author

@oscardssmith how the Rosenbrock32 and Rosenbrock23 be combined ?? Most of the test here failed because they are defined but maybe we need to combine them with the RosenbrockCache

@ParamThakkar123
Copy link
Contributor Author

Rosenbrock32 and Rosenbrock23 have some extra fields in their caches compared to the RosenbrockCache

@oscardssmith
Copy link
Contributor

Rosenbrock23 and 32 will need some extra work. Also you will need to make sure you're on a version of master new enough to include #2307 since otherwise it will be totally broken.

@ParamThakkar123
Copy link
Contributor Author

Rosenbrock23 and 32 will need some extra work. Also you will need to make sure you're on a version of master new enough to include #2307 since otherwise it will be totally broken.

Okay. I need to pull #2307 from the upstream master in my branch

@ParamThakkar123
Copy link
Contributor Author

image

@oscardssmith how do I fix this failure ??

@oscardssmith oscardssmith mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscardssmith oscardssmith Awaiting requested review from oscardssmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ParamThakkar123 @oscardssmith